Skip to content

Conversation

@clee2000
Copy link
Contributor

Dunno how this didn't fail immediately, will need to investigate later

@vercel
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 4:57am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2024
@clee2000 clee2000 changed the title Update rockset query for test class times [ez] Update rockset query for test class times Jan 12, 2024
@clee2000 clee2000 marked this pull request as ready for review January 12, 2024 04:57
@clee2000 clee2000 requested a review from a team January 12, 2024 05:01
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I' trying to guess what was wrong with the previous query, is class a protected keyword or something?

@clee2000
Copy link
Contributor Author

the code looks for classname and errors when it cant find it

@clee2000 clee2000 merged commit 5a8239d into main Jan 12, 2024
@clee2000
Copy link
Contributor Author

Dunno how this didn't fail immediately, will need to investigate later

My investigation failed, I still have no idea how this got through

@clee2000 clee2000 deleted the csl/fix_query branch April 15, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants