Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jan 11, 2024

Learn from the previous attempt
#4842:

  • Keep the secrets param for now till we clean up all domains workflow.
  • The role gha_workflow_build_wheels needs to come from pytorch account instead of fbossci (D52679407)
  • Per @malfet suggestion, I'm splitting the role into one for nightly and one for test. They require different ref conditions anyway.
  • I'll move the uploading part to a separate job in a separate PR to keep this one simple.

Learn from the previous attempt
pytorch#4842:

* [x] Keep the secrets param for now till we clean up all domains
workflow.
* [x] The role `gha_workflow_build_wheels` needs to come from pytorch
account instead of fbossci (D52679407)
* [x] Per @malfet suggestion, I'm splitting the role into one for
nightly and one for test. They require different ref conditions anyway.
* [ ] I'll move the uploading part to a separate job in a separate PR to
keep this one simple.
@vercel
Copy link

vercel bot commented Jan 11, 2024

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2024
@vercel
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 11:48pm

@atalman atalman merged commit b35cb82 into pytorch:release/2.2 Jan 12, 2024
@atalman atalman deleted the cherry_pick_oidc branch January 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants