Enable nightly 3.12 for all domains #4834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
atalman
approved these changes
Dec 18, 2023
malfet
approved these changes
Dec 18, 2023
Contributor
Author
|
Conda torchtext build failures are caused by torchdata, which doesn't have 3.12 ready. It's easier to just merge this change and rebuild torchdata nightly |
atalman
pushed a commit
to atalman/test-infra
that referenced
this pull request
Dec 20, 2023
Remove the custom tweak for 3.12 wheel and enable 3.12 for all domains in both wheel and conda builds. If nightly looks ok after this, we should continue to enable 3.12 for test and release according to 2.2.0 release matrix.
This was referenced Dec 20, 2023
atalman
added a commit
that referenced
this pull request
Dec 20, 2023
Follow up of: #4834 Make sure we have python 3.12 in test env
atalman
added a commit
that referenced
this pull request
Dec 20, 2023
Cherry Pick of #4834 Add 3.12 to test environment --------- Co-authored-by: Huy Do <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the custom tweak for 3.12 wheel and enable 3.12 for all domains in both wheel and conda builds. If nightly looks ok after this, we should continue to enable 3.12 for test and release according to 2.2.0 release matrix.