Skip to content

Update VS 2019 and add VS 2022 to Windows AMI #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2023
Merged

Update VS 2019 and add VS 2022 to Windows AMI #1175

merged 1 commit into from
Jun 8, 2023

Conversation

Blackhex
Copy link
Contributor

@Blackhex Blackhex commented Nov 23, 2022 •
edited
Loading

This adds VS 2022 to Windows AMI. The line with https://aka.ms/ link might be reverted once vs16.11.21_BuildTools.exe and vs17.4.1_BuildTools.exe files will be uploaded to https://s3.amazonaws.com/ossci-windows/.

Note that there is a fix of thread_local causing fatal error LNK1161: invalid export specification on VS 2022 - Visual Studio Feedback pending, required e.g. for pytorch/pytorch#89511, which will require another VS 2022 version update. Alternatively, the VS 2022 version installed by this change can be downgraded to 16.3.6 which does not suffer this issue.

This is needed to finish pytorch/pytorch#86591

@vercel
Copy link

vercel bot commented Nov 23, 2022

@Blackhex is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2022
@vercel
Copy link

vercel bot commented Nov 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
torchci ⬜️ Ignored (Inspect) Nov 23, 2022 at 10:57PM (UTC)

@Blackhex Blackhex mentioned this pull request Nov 29, 2022
Closed
@Blackhex
Copy link
Contributor Author

Blackhex commented Dec 5, 2022

@seemethere, @izaitsevfb Please advise how to proceed with this PR. Whether it is required that the fix to the VS build tools issue must be released to public, or should I downgrade the VS version to 17.3.6, or can it be merged with the current version of the build tools and updated when the fix will be released?

@Blackhex Blackhex mentioned this pull request Dec 6, 2022
Closed
@atalman
Copy link
Contributor

atalman commented Dec 8, 2022 •
edited
Loading

This looks ok, however we would need to build the AMI and test it in pytorch-canary before shipping this PR
Building AMI process: https://github.com/pytorch/test-infra/tree/main/aws/ami/windows
Deploy to canary: https://github.com/fairinternal/pytorch-gha-infra/pull/89/files
Test: https://github.com/pytorch/pytorch-canary/pull/153

Before building rebase is needed
After all tests are successful we can merge

@atalman
Copy link
Contributor

atalman commented Dec 8, 2022

@pytorchbot rebase -b main

@Blackhex
Copy link
Contributor Author

Blackhex commented Dec 9, 2022 •
edited
Loading

@atalman The branch is rebased but I cannot do the deploy and test it myself. I've build the AMI and deployed it to my own AWS account though.

@Blackhex Blackhex force-pushed the vs-2022-build branch 3 times, most recently from ff33a73 to f446e9d Compare December 13, 2022 07:55
@Blackhex
Copy link
Contributor Author

@atalman Please advise what should I do more to test and merge this PR.

@Blackhex Blackhex mentioned this pull request Apr 19, 2023
Open
@huydhn
Copy link
Contributor

huydhn commented Apr 19, 2023 •
edited
Loading

Let me setup sometime later today to test this one, building and testing the AMI needs AWS credential from Dev Infra team. I will send you the test PR once I have it

@Blackhex
Copy link
Contributor Author

Blackhex commented May 9, 2023

@huydhn Any update on this? Do you need some assistance/help?

@huydhn
Copy link
Contributor

huydhn commented May 9, 2023

@huydhn Any update on this? Do you need some assistance/help?

I was blocked on this because of other recent changes on Windows infra (new AMI, switching runner). Let me pick this up.

This was referenced May 15, 2023
Closed
Merged
@atalman atalman merged commit 998093b into pytorch:main Jun 8, 2023
@Blackhex Blackhex deleted the vs-2022-build branch June 9, 2023 09:15
Blackhex added a commit to Blackhex/pytorch-test-infra that referenced this pull request Jun 13, 2023
@Blackhex
Fix VS2022 Build Tools installation removing VS2019, fixes pytorch#1175
f4857bd
@Blackhex Blackhex mentioned this pull request Jun 13, 2023
Merged
Blackhex added a commit to Blackhex/pytorch-test-infra that referenced this pull request Jun 13, 2023
@Blackhex
Fix VS2022 Build Tools installation removing VS2019, fixes pytorch#1175
4103bfe
atalman pushed a commit that referenced this pull request Jun 13, 2023
@Blackhex
Fix VS2022 Build Tools installation removing VS2019, fixes #1175 (#4288)
8f97379 
Fixes issue that the VS2022 Build Tools installation is removing VS2019
Build Tools installation. This is a follow up fix of already merged
#1175.
@Blackhex Blackhex mentioned this pull request May 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

@seemethere seemethere Awaiting requested review from seemethere

@izaitsevfb izaitsevfb Awaiting requested review from izaitsevfb

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackhex @atalman @huydhn @facebook-github-bot