-
Notifications
You must be signed in to change notification settings - Fork 107
Open
Labels
enhancementNew feature or requestNew feature or request
Description
We have been impacted by this several times when devs unknowingly create a large stack of size 10+:
- The stack will hook up a big chunk, may be all of CI resources, preventing other people to run their jobs.
- In addition, a large stack like [codemod] markDynamoStrictTest batch pytorch#116745 could also cause failures further down the line in diff train, i.e. D52549880
We need to take more active action here to prevent the issue from happening. Some thoughts:
- We could create a CI check running before other jobs stopping them from running in the first place when the stack size is larger than a threshold
- or updating ghstack to automatically add
[no ci]into the commit message for large stack https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs
In any cases, a clear message will need to be communicated with the owner of the stack about what happen (CI not running) and what they could do to fix it (squash commits, breaking up the stack)
cc @malfet @seemethere @izaitsevfb @kit1980 @clee2000 @PaliC
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Type
Projects
Status
Cold Storage