Skip to content

[codev] Move PyTorch-specific logic from github-export-checks into a different check #4815

@huydhn

Description

@huydhn

Atm, github-export-checks both checks if a diff has been exported and can be merged, the generic part that applies to all repos, and also run specific checks for PyTorch (have reviewer, CLA, green PR signals). This is a common source of confusion leading to the abuse using of the bypass flag. For example, github-export-checks will always be red when a diff is first created.

Aiming for a better UX here, let's take the PyTorch-specific logic of github-export-checks and move it to a different check that we can maintain:

  • The generic part for checking if a diff with OSS content has been exported and can be merged should remain the same
  • There is a new check for checking the PyTorch PR status including reviewer, CLA, and PR signals. This part comes from trymerge

cc @PaliC @clee2000 @kit1980

Update from @PaliC is that works can be done to split this into the a generic part and a PyTorch-specific part.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions