Skip to content

[chalf] abs, sgn #77446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[chalf] abs, sgn #77446

wants to merge 7 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented May 13, 2022 •
edited
Loading

Ref: #74537

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 13, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit ef430a1 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345 kshitij12345 marked this pull request as ready for review May 14, 2022 14:40
@kshitij12345 kshitij12345 requested a review from anjali411 May 14, 2022 14:40
@anjali411 anjali411 mentioned this pull request May 16, 2022
Closed
@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented May 16, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@kshitij12345 kshitij12345 deleted the develop/chalf/abs-sgn branch May 16, 2022 15:33
@kshitij12345 kshitij12345 added module: complex Related to complex number support in PyTorch module: half Related to float16 half-precision floats labels May 16, 2022
facebook-github-bot pushed a commit that referenced this pull request May 17, 2022
@kshitij12345 @facebook-github-bot
[chalf] abs, sgn (#77446) (#77446)
ae38dd9 
Summary:
Ref: #74537

Pull Request resolved: #77446
Approved by: https://github.com/anjali411

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3feb038421fb6645b314f83934add2d958f58e64

Reviewed By: atalman

Differential Revision: D36421526

Pulled By: atalman

fbshipit-source-id: fa6fbb8d1d82c5d64e617ecad20a93c2b597dda8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

cla signed Merged module: complex Related to complex number support in PyTorch module: half Related to float16 half-precision floats open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kshitij12345 @facebook-github-bot @anjali411 @pytorchbot @pytorchmergebot