[JIT] add support for ModuleDict #25715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
driazati
reviewed
Sep 10, 2019
Contributor
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
Mostly good, a couple small questions
| x = mod(x) | ||
|
|
||
| for mod in self.moduledict.values(): | ||
| x = mod(x) |
Contributor
There was a problem hiding this comment.
This only checks the value is right for the last module in the dict, the results should go into a list or something so they can all be checked
Contributor
Author
There was a problem hiding this comment.
Well, the three modules that i have aren't commutative so it's checking that the order is correct.
test/test_jit.py
Outdated
|
|
||
| return x, names | ||
|
|
||
| m = M() |
Contributor
There was a problem hiding this comment.
checkModule does this same thing
Line 14837 in 7ab4ad7
driazati
approved these changes
Sep 10, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for nn.ModuleDict in script. This is needed to support torchvision.