[jit] Add source location to class instantiation error #24990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
added 2 commits
August 21, 2019 16:59
eellison
approved these changes
Aug 26, 2019
Contributor
eellison
left a comment
eellison
left a comment
There was a problem hiding this comment.
Looks good. It would be nice if the error had the same stacktrace as with a JIT compilation error
Contributor
Author
|
Contributor
Member
|
This PR broke pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test. I am reverting |
Member
|
The PR doesn't revert cleanly (I assume because of the fix for the lint breakage also caused by this PR). @driazati can you issue a fix asap? |
Contributor
Author
|
Fix in #25378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24987
Differential Revision: D17099779