Skip to content

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Aug 2, 2019

No description provided.

@pytorchbot pytorchbot added the module: nn Related to torch.nn label Aug 2, 2019
@ssnl ssnl mentioned this pull request Aug 2, 2019
@ssnl
Copy link
Collaborator Author

ssnl commented Aug 2, 2019

cc @bnehoran

Copy link
Contributor

@bnehoran bnehoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor grammatical change if we're already modifying the line. Really not important.
Otherwise looks good.

ssnl and others added 2 commits August 1, 2019 22:44
@ssnl
Copy link
Collaborator Author

ssnl commented Aug 2, 2019

@bnehoran Thanks!

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Aug 2, 2019
@bnehoran
Copy link
Contributor

bnehoran commented Aug 2, 2019

@ssnl I think you may have the wrong pull request number listed at the bottom of #23555 (comment)

@ssnl
Copy link
Collaborator Author

ssnl commented Aug 2, 2019

@bnehoran fixed!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@vincentqb
Copy link
Contributor

This looks good to me. I'll land.

@vincentqb vincentqb added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 2, 2019
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 3107f1d.

@ssnl ssnl deleted the SsnL-patch-1 branch August 22, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants