-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[dynamo, 3.14] Ensure typing.Union is correctly traced in Dynamo.
#169084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dynamo, 3.14] Ensure typing.Union is correctly traced in Dynamo.
#169084
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169084
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
|
@pytorchbot merge |
|
@pytorchbot rebase |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
|
@pytorchmergebot merge -f "Pending ROCm" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Fixes `test_vector_norm_decom_unbacked_checks_cpu` from `test/test_linalg.py` on Python 3.14 X-link: pytorch/pytorch#169084 Approved by: https://github.com/rtimpe, https://github.com/williamwen42 Reviewed By: wdvr Differential Revision: D88036656 fbshipit-source-id: 34d374685fc18a03afd2bcd2509b4a5566b24940
…169084) Fixes `test_vector_norm_decom_unbacked_checks_cpu` from `test/test_linalg.py` on Python 3.14 Pull Request resolved: #169084 Approved by: https://github.com/rtimpe, https://github.com/williamwen42
Stack from ghstack (oldest at bottom):
typing.Unionis correctly traced in Dynamo. #169084Fixes
test_vector_norm_decom_unbacked_checks_cpufromtest/test_linalg.pyon Python 3.14cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo