-
Notifications
You must be signed in to change notification settings - Fork 26k
[pc] migrate progression futures from list to deque #157614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157614
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit be05e6c with merge base c808af5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| self._fast_output_code = fast_output_code | ||
| self._optimized_output_code = None | ||
| self._progression_futures = list(progression_futures) | ||
| self._progression_futures = deque(progression_futures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Above (github won't let me comment on unchanged lines):
progression_futures: Sequence[Future[_WireProtocolPickledOutput]],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem is then mypy complains about no popleft
Error (MYPY) [attr-defined]
"Sequence[Future[_WireProtocolPickledOutput]]" has no attribute "popleft"
268 |
269 | # Clear earlier progression futures to free memory
270 | for _ in range(stage_index + 1):
>>> 271 | self._progression_futures.popleft()
272 |
273 | @override
274 | def post_compile(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you misunderstood. I meant the init signature should take Sequence. The instance member should still be deque. (I can see that what I wrote wasn't clear)
|
Starting merge as part of PR stack under #157650 |
Pull Request resolved: #157650 Approved by: https://github.com/aorenste ghstack dependencies: #157305, #157614, #157619
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov