[logging] Add python version to dynamo_compile table #149419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This adds a version field like the following: `3.10.9+fb (3.10:1dd9be6, May 4 2022, 01:23:45) [Clang 15.0.7 (mononoke://mononoke.internal.tfbnw.net/fbsource 5d1601b0eed7426ac` [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149419
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit d8c4632 with merge base 790f93d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
masnesral
added
topic: not user facing
c00w
approved these changes
Mar 20, 2025
c00w
reviewed
Mar 20, 2025
| "triton_version": triton.__version__ if has_triton() else "", | ||
| "remote_cache_version": remote_cache_version, | ||
| "inductor_fx_remote_cache_backend_type": inductor_fx_remote_cache_backend_type, | ||
| "python_version": sys.version, |
Contributor
There was a problem hiding this comment.
Should we use sys.platform here? (Not sure how it differs with sys.version, but whichever ones tells us the most would be useful).
Contributor
Author
There was a problem hiding this comment.
Looks like we want version because sys.platform just says "linux"
c00w
reviewed
Mar 20, 2025
| triton_kernel_compile_times_us: Optional[str] = None | ||
| ir_count: Optional[int] = None | ||
| cudagraph_skip_reason: Optional[str] = None | ||
| python_version: Optional[str] = None |
Contributor
Author
There was a problem hiding this comment.
meh, I can't really imagine such a test catching a real problem. Famous last words :( ?
c00w
approved these changes
Mar 20, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Mar 20, 2025
Summary: This adds a version field like the following: `3.10.9+fb (3.10:1dd9be6, May 4 2022, 01:23:45) [Clang 15.0.7 (mononoke://mononoke.internal.tfbnw.net/fbsource 5d1601b0eed7426ac` X-link: pytorch/pytorch#149419 Approved by: https://github.com/c00w Reviewed By: izaitsevfb Differential Revision: D71530503 fbshipit-source-id: 901e254d7d221738d575c45e415c8fff9daa30f0
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Summary: This adds a version field like the following: `3.10.9+fb (3.10:1dd9be6, May 4 2022, 01:23:45) [Clang 15.0.7 (mononoke://mononoke.internal.tfbnw.net/fbsource 5d1601b0eed7426ac` Pull Request resolved: pytorch#149419 Approved by: https://github.com/c00w
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: This adds a version field like the following:
3.10.9+fb (3.10:1dd9be6, May 4 2022, 01:23:45) [Clang 15.0.7 (mononoke://mononoke.internal.tfbnw.net/fbsource 5d1601b0eed7426accc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames