[XPTI] introduce new interface to kineto for PTI-0.11 and PTI-0.12 #1066

zejun-chen · 2025-03-26T01:24:23Z

This PR is used to change the interface for XPTI in kineto to be compatible with the PTI 0.11 release

gujinghui · 2025-03-26T07:12:36Z

libkineto/src/plugin/xpupti/XpuptiActivityApi.cpp

+    XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMHostAlloc_id));
+    XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMSharedAlloc_id));
+    XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMDeviceAlloc_id));
+}


why we still need these UR specific API ids? we should use API set?

Yes. We will use API set, just apply the previous patch and open a draft PR.

then, can we make this PR as a draft?

zejun-chen · 2025-04-08T07:52:48Z

Hi, @aaronenyeshi

Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools.

Thank you.

zejun-chen · 2025-04-14T01:38:23Z

Hi, @aaronenyeshi

Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools.

Thank you.

sraikund16 · 2025-04-15T17:21:54Z

libkineto/src/plugin/xpupti/XpuptiActivityApi.cpp

 }
 #endif

+#if PTI_VERSION_MAJOR > 0 || PTI_VERSION_MINOR > 10


Might be useful to use a version schema similar to cuda where they embed the MAJOR, MINOR and PATCH number into one number. If you use OR statements like this it can lead to more complexity if many ifdefs are needed

Hi, @sraikund16
Thank you for good suggestion.
For now, intel GPU doesn't have capability version control API. Only XPTI has release version macro so we use it here to do conditional building. We will consider to add the capability version control then refine here.
Thank you.

facebook-github-bot · 2025-04-15T17:22:17Z

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

sraikund16 · 2025-04-15T17:22:52Z

Hi, @aaronenyeshi

Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools.

Thank you.

Aaron is not actively maintaining Kineto currently. You can reach out to me for future requests!

zejun-chen · 2025-04-16T03:03:44Z

Hi, @aaronenyeshi
Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools.
Thank you.

Aaron is not actively maintaining Kineto currently. You can reach out to me for future requests!

Thank you @sraikund16 Really appreciate that
BTW, after you imported the PR, can we still push the commit to this PR? We may also need to do some modification, for example, use version schema for building.

sraikund16 · 2025-04-16T16:58:54Z

Hi, @aaronenyeshi
Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools.
Thank you.

Aaron is not actively maintaining Kineto currently. You can reach out to me for future requests!

Thank you @sraikund16 Really appreciate that BTW, after you imported the PR, can we still push the commit to this PR? We may also need to do some modification, for example, use version schema for building.

Absolutely, we can always re-import. Please update as you need.

facebook-github-bot · 2025-04-21T00:43:09Z

@zejun-chen has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-21T00:43:19Z

@zejun-chen has updated the pull request. You must reimport the pull request before landing.

the xpu profiler in pytorch Signed-off-by: Chen, Zejun <[email protected]>

zejun-chen · 2025-04-21T05:09:29Z

Hi, @sraikund16
Could you help review and reimport this PR? We use this PR to support the XPTI new release version(0.11 and 0.12 version).
Thank you.

facebook-github-bot · 2025-04-21T19:08:28Z

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-21T21:35:05Z

@zejun-chen has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-21T21:37:27Z

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-22T17:24:38Z

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-22T18:50:46Z

@sraikund16 merged this pull request in fb36cce.

facebook-github-bot added the cla signed label Mar 26, 2025

zejun-chen changed the title ~~[XPTI] introduce new interface to kineto for PTI0.11~~ [WIP][XPTI] introduce new interface to kineto for PTI0.11 Mar 26, 2025

gujinghui reviewed Mar 26, 2025

View reviewed changes

zejun-chen marked this pull request as draft March 27, 2025 00:59

zejun-chen force-pushed the zejun/kineto_for_pti_0.11 branch from aebebe7 to a41d6f7 Compare April 1, 2025 01:17

zejun-chen changed the title ~~[WIP][XPTI] introduce new interface to kineto for PTI0.11~~ [WIP][XPTI] introduce new interface to kineto for PTI-0.11 Apr 1, 2025

zejun-chen changed the title ~~[WIP][XPTI] introduce new interface to kineto for PTI-0.11~~ [XPTI] introduce new interface to kineto for PTI-0.11 Apr 1, 2025

zejun-chen marked this pull request as ready for review April 1, 2025 08:32

anmyachev mentioned this pull request Apr 4, 2025

PyTorch build failure with DLE 2025.1.0 intel/intel-xpu-backend-for-triton#3769

Closed

chuanqi129 mentioned this pull request Apr 11, 2025

[XPU] Upgrade the XPU support packages version to 2025.1 in CI/CD pytorch/pytorch#151097

Closed

14 tasks

sraikund16 reviewed Apr 15, 2025

View reviewed changes

zejun-chen force-pushed the zejun/kineto_for_pti_0.11 branch from 7f811c2 to 378aab4 Compare April 21, 2025 00:43

zejun-chen added 2 commits April 21, 2025 08:49

[XPTI] introduce the PTI 0.11 and PTI 0.12 for

378aab4

the xpu profiler in pytorch Signed-off-by: Chen, Zejun <[email protected]>

Merge branch 'main' into zejun/kineto_for_pti_0.11

7c587a9

zejun-chen changed the title ~~[XPTI] introduce new interface to kineto for PTI-0.11~~ [XPTI] introduce new interface to kineto for PTI-0.11 and PTI-0.12 Apr 21, 2025

lint and copyright

1d75932

facebook-github-bot closed this in fb36cce Apr 22, 2025

facebook-github-bot added the Merged label Apr 22, 2025

[XPTI] introduce new interface to kineto for PTI-0.11 and PTI-0.12 #1066

[XPTI] introduce new interface to kineto for PTI-0.11 and PTI-0.12 #1066

Conversation

zejun-chen commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gujinghui Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

zejun-chen Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

gujinghui Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

zejun-chen commented Apr 8, 2025

Uh oh!

zejun-chen commented Apr 14, 2025

Uh oh!

sraikund16 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

zejun-chen Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 15, 2025

Uh oh!

sraikund16 commented Apr 15, 2025

Uh oh!

zejun-chen commented Apr 16, 2025

Uh oh!

sraikund16 commented Apr 16, 2025

Uh oh!

facebook-github-bot commented Apr 21, 2025

Uh oh!

facebook-github-bot commented Apr 21, 2025

Uh oh!

zejun-chen commented Apr 21, 2025

Uh oh!

facebook-github-bot commented Apr 21, 2025

Uh oh!

facebook-github-bot commented Apr 21, 2025

Uh oh!

facebook-github-bot commented Apr 21, 2025

Uh oh!

facebook-github-bot commented Apr 22, 2025

Uh oh!

facebook-github-bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zejun-chen commented Mar 26, 2025 •

edited

Loading