Deprecate use_default_config and replace all its uses with autotune_effort #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
choijon5
force-pushed
the
deprecate_use_default_config
branch
from
1dd663b to
2d7c3b5
Compare
jansel
approved these changes
Oct 14, 2025
oulgen
approved these changes
Oct 14, 2025
Contributor
oulgen
left a comment
oulgen
left a comment
There was a problem hiding this comment.
should we support autotune_effort=None?
Contributor
Author
|
It seems probable that users will make mistakes with uppercase letters. Will put up another PR. |
Contributor
I dont only mean the string, but when used as a config, it is very pythonic to pass None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_default_config=True is now replaced with autotune_effort="none".