skip gather_gemv code check for B200 and fb_code #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #666, branch: Sibylau/stack/4
meta-cla
bot
added
the
CLA Signed
Sibylau
force-pushed
the
Sibylau/stack/4
branch
from
67635cb to
bfd598c
Compare
yf225
reviewed
Sep 24, 2025
test/test_examples.py
Outdated
| if is_cuda(): | ||
| gpu_name = torch.cuda.get_device_name(0) | ||
|
|
||
| if is_cuda() and not is_fbcode() and "b200" not in gpu_name.lower(): |
Contributor
There was a problem hiding this comment.
Wonder does https://github.com/pytorch/helion/actions/runs/17962225347/job/51087773640 repro on local H100 machine as well? I haven't quite figured out why it fails also on H100... I think worse case we could skip the assertExpectedJournal for gather_gemv for now
Contributor
Author
There was a problem hiding this comment.
The test_gather_gemv passes on my local H100 and B200. I am not sure why the generated code varies in the CI runner... Let me skip the assertExpectedJournal for gather_gemv.
yf225
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
skip gather_gemv code check for B200 and fb_code