Support layernorm without bias #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 11, 2025
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
800873f to
9b722ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 11, 2025
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
9b722ee to
9c751e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 11, 2025
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
9c751e0 to
5540fd8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 11, 2025
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
5540fd8 to
95b363d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
oulgen
approved these changes
Sep 11, 2025
yf225
reviewed
Sep 11, 2025
| baseline_name="torch", | ||
| rtol=1e-3, | ||
| atol=1e-3, | ||
| ) |
Contributor
There was a problem hiding this comment.
@mengluy0125 thanks for the PR! would you like to add the no-bias test in test_examples.py too?
Lines 614 to 628 in 247be92
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 11, 2025
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
95b363d to
c19532d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
Summary: The current layernorm only supports bias case, we thus add the case without bias. Differential Revision: D82171738
mengluy0125
force-pushed
the
export-D82171738
branch
from
c19532d to
af875dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82171738 |
lolpack
pushed a commit
to lolpack/helion
that referenced
this pull request
Oct 13, 2025
Differential Revision: D82171738 Pull Request resolved: pytorch#585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current layernorm only supports bias case, we thus add the case without bias.
Differential Revision: D82171738