Add jagged hstu attention example (i.e. ragged_attention) #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
xuanzhang816
commented
Aug 29, 2025
[ghstack-poisoned]
[ghstack-poisoned]
yf225
reviewed
Aug 29, 2025
examples/jagged_hstu_attn.py
Outdated
| ) | ||
|
|
||
|
|
||
| def tritonbench_hstu_attention_function(inputs: dict[str, Any]) -> torch.Tensor: |
Contributor
There was a problem hiding this comment.
Curious does it pass accuracy check compared to ragged_attention in tritonbench? If so, maybe we can add a dispatch in KERNEL_MAPPINGS in benchmarks/run.py to integrate with tritonbench.
Contributor
Author
There was a problem hiding this comment.
Done :) Could you check and make sure that I added things to KERNEL_MAPPINGS correctly?
yf225
reviewed
Aug 29, 2025
| @@ -0,0 +1,291 @@ | |||
| """ | |||
Contributor
There was a problem hiding this comment.
Would be great to add a test in test_examples.py too. Thanks!
Contributor
Author
There was a problem hiding this comment.
Added this one as well. Let me if I missed something.
yf225
requested changes
Aug 29, 2025
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
thanks! left some inline comments above
[ghstack-poisoned]
74 tasks
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
yf225
requested changes
Sep 3, 2025
yf225
changed the title
[ghstack-poisoned]
jansel
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):