-
Notifications
You must be signed in to change notification settings - Fork 70
[example] fused_linear_jsd #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jansel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test and __main__ for this similar to the other examples?
fed64ce to
157f1e3
Compare
435b56f to
392a26d
Compare
4d576ec to
d3f0fa0
Compare
0a56fdb to
aafe47a
Compare
yf225
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @v0i0 !
|
@v0i0 the internal error on expected string mismatch is weird... if a rebase doesn't fix it, we could gate it with |
you dont need to define is_fbcode again, just import it from pytorch like |
|
@yf225 will rebase again, looks like that's needed anyways. don't see why it would otherwise fail... |
aafe47a to
3cbfb0f
Compare
3cbfb0f to
c8a3bc7
Compare
c8a3bc7 to
6bd9219
Compare
6bd9219 to
ca3be2f
Compare
637eee9 to
7f58bb5
Compare
7f58bb5 to
d24fd5d
Compare
No description provided.