Skip to content

Conversation

@v0i0
Copy link
Contributor

@v0i0 v0i0 commented Aug 13, 2025

No description provided.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 13, 2025
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test and __main__ for this similar to the other examples?

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from fed64ce to 157f1e3 Compare August 14, 2025 18:47
@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch 2 times, most recently from 435b56f to 392a26d Compare August 18, 2025 17:40
@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch 5 times, most recently from 4d576ec to d3f0fa0 Compare September 9, 2025 22:58
@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch 2 times, most recently from 0a56fdb to aafe47a Compare September 17, 2025 19:22
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @v0i0 !

@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@yf225
Copy link
Contributor

yf225 commented Sep 17, 2025

@v0i0 the internal error on expected string mismatch is weird... if a rebase doesn't fix it, we could gate it with not is_fbcode() (can add it to _testing.py):

def is_fbcode() -> bool:
    return not hasattr(torch.version, "git_version")

@oulgen
Copy link
Contributor

oulgen commented Sep 18, 2025

@v0i0 the internal error on expected string mismatch is weird... if a rebase doesn't fix it, we could gate it with not is_fbcode() (can add it to _testing.py):

def is_fbcode() -> bool:
    return not hasattr(torch.version, "git_version")

you dont need to define is_fbcode again, just import it from pytorch like

from torch._environment import is_fbcode

@v0i0
Copy link
Contributor Author

v0i0 commented Sep 18, 2025

@yf225 will rebase again, looks like that's needed anyways. don't see why it would otherwise fail...

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from aafe47a to 3cbfb0f Compare September 18, 2025 09:31
@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from 3cbfb0f to c8a3bc7 Compare September 19, 2025 16:18
@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from c8a3bc7 to 6bd9219 Compare September 19, 2025 16:45
@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from 6bd9219 to ca3be2f Compare September 21, 2025 13:07
@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch 2 times, most recently from 637eee9 to 7f58bb5 Compare September 23, 2025 16:15
@facebook-github-bot
Copy link

@v0i0 has imported this pull request. If you are a Meta employee, you can view this in D82675849.

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from 7f58bb5 to d24fd5d Compare September 24, 2025 21:33
@v0i0 v0i0 merged commit f25a771 into pytorch:main Sep 24, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants