Modernize extension-cpp; refactor code #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: - creates a single unified build for extension-cpp (instead of having separate cpu/cuda setup.pys). - Updates the build system to use pyproject.toml (instead of only setup.py) - Uses TORCH_LIBRARY to bind operators (instead of using PyBind) There will be more future work to add improvements (e.g. torch.compile support) and also fix up the corresponding C++ extensions tutorial. Test Plan: - Refactored all of the tests under test/ [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Apr 10, 2024
This PR: - creates a single unified build for extension-cpp (instead of having separate cpu/cuda setup.pys). - Updates the build system to use pyproject.toml (instead of only setup.py) - Uses TORCH_LIBRARY to bind operators (instead of using PyBind) There will be more future work to add improvements (e.g. torch.compile support) and also fix up the corresponding C++ extensions tutorial. Test Plan: - Refactored all of the tests under test/ ghstack-source-id: 9c3f83a Pull Request resolved: #86
drisspg
reviewed
Apr 10, 2024
This PR: - creates a single unified build for extension-cpp (instead of having separate cpu/cuda setup.pys). - Updates the build system to use pyproject.toml (instead of only setup.py) - Uses TORCH_LIBRARY to bind operators (instead of using PyBind) There will be more future work to add improvements (e.g. torch.compile support) and also fix up the corresponding C++ extensions tutorial. Test Plan: - Refactored all of the tests under test/ [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Apr 10, 2024
This PR: - creates a single unified build for extension-cpp (instead of having separate cpu/cuda setup.pys). - Updates the build system to use pyproject.toml (instead of only setup.py) - Uses TORCH_LIBRARY to bind operators (instead of using PyBind) There will be more future work to add improvements (e.g. torch.compile support) and also fix up the corresponding C++ extensions tutorial. Test Plan: - Refactored all of the tests under test/ ghstack-source-id: a31d059 Pull Request resolved: #86
bdhirsh
approved these changes
Apr 15, 2024
zou3519
added a commit
that referenced
this pull request
Apr 24, 2024
This PR: - creates a single unified build for extension-cpp (instead of having separate cpu/cuda setup.pys). - Updates the build system to use pyproject.toml (instead of only setup.py) - Uses TORCH_LIBRARY to bind operators (instead of using PyBind) There will be more future work to add improvements (e.g. torch.compile support) and also fix up the corresponding C++ extensions tutorial. Test Plan: - Refactored all of the tests under test/ ghstack-source-id: a31d059 Pull Request resolved: #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR:
separate cpu/cuda setup.pys).
setup.py)
There will be more future work to add improvements (e.g. torch.compile
support) and also fix up the corresponding C++ extensions tutorial.
Test Plan: