[release/0.1] Cherry-pick docs-only commits #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #922 Make sure that the list of tutorials in the left-hand nav section agrees with the set of tutorial cards. Rearrange the tutorials to do more general ones first, then mobile apps (which will probably have a larger audience), then an alphabetical list of backend examples. Reviewed By: mergennachin, kimishpatel Differential Revision: D50302244 fbshipit-source-id: a1431264cfdbb983cf6b9ad116eac83fb70c120e
Summary: Pull Request resolved: #911 ^ Reviewed By: vmpuri Differential Revision: D50289382 fbshipit-source-id: 7898a76b852b628da2ae15864b9ed17b5530c0b5
Summary: Pull Request resolved: #926 On the left hand side, the tutorial titles are not consistent with tutorial cards. I like dbort change D50302244. Let's just make sure the titles are also consistent across the board. Both on left hand nav as well as the actual pages. Reviewed By: dbort Differential Revision: D50302650 fbshipit-source-id: a0bd94d717150041f63e1fdc639763ae874fc96b
Summary: Pull Request resolved: #931 This was the only reference I found to the preview hostname in the tree. Reviewed By: mergennachin Differential Revision: D50307683 fbshipit-source-id: b20847d8b5ca6a13f881708fa8bad809b29dddb7
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
facebook-github-bot
added
the
CLA Signed
mergennachin
approved these changes
Oct 15, 2023
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to resolve two commits manually, and because their diffs are different from the commits in main, they're going to keep showing up in the list of recommended commits printed by pick_doc_commits.py:
I might update the tool to have a blocklist of commits like this, or see if I can make it smarter, but for now I'll just remember to remove these two commits when cherry-picking future batches.