Skip to content

Skip grain_size computation in parallel_for_each_reduce_* wrappers without threadpool #9144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 141 commits into from
Mar 14, 2025
Merged

Skip grain_size computation in parallel_for_each_reduce_* wrappers without threadpool #9144

merged 141 commits into from
Mar 14, 2025

Conversation

swolchok
Copy link
Contributor

If we don't have the threadpool then this division is wasted.

swolchok added 30 commits March 4, 2025 11:35
@swolchok
Update
d0b11e8 
[ghstack-poisoned]
@swolchok
Update
9437be1 
[ghstack-poisoned]
@swolchok
Update
643e10e 
[ghstack-poisoned]
@swolchok
Update
6f2842b 
[ghstack-poisoned]
@swolchok
Update
e47dfeb 
[ghstack-poisoned]
@swolchok
Update
231ebc3 
[ghstack-poisoned]
@swolchok
Update
296513c 
[ghstack-poisoned]
@swolchok
Update
845a01e 
[ghstack-poisoned]
@swolchok
Update
a92958a 
[ghstack-poisoned]
@swolchok
Update
3fa99d6 
[ghstack-poisoned]
@swolchok
Update
a6c69a6 
[ghstack-poisoned]
@swolchok
Update
3bd6437 
[ghstack-poisoned]
@swolchok
Update
675f01b 
[ghstack-poisoned]
@swolchok
Update
5f3a768 
[ghstack-poisoned]
@swolchok
Update
9fdebee 
[ghstack-poisoned]
@swolchok
Update
70a7096 
[ghstack-poisoned]
@swolchok
Update
337dc23 
[ghstack-poisoned]
@swolchok
Update
f388177 
[ghstack-poisoned]
@swolchok
Update
2949daf 
[ghstack-poisoned]
@swolchok
Update
7347915 
[ghstack-poisoned]
@swolchok
Update
1a8481d 
[ghstack-poisoned]
@swolchok
Update
e48e816 
[ghstack-poisoned]
@swolchok
Update
3351d50 
[ghstack-poisoned]
@swolchok
Update
0102e25 
[ghstack-poisoned]
@swolchok
Update
956f8a5 
[ghstack-poisoned]
@swolchok
Update
9f7f0c1 
[ghstack-poisoned]
@swolchok
Update
a1aeae7 
[ghstack-poisoned]
@swolchok
Update
c658163 
[ghstack-poisoned]
@swolchok
Update
7e0ccd4 
[ghstack-poisoned]
@swolchok
Update
d9cd27c 
[ghstack-poisoned]
swolchok added 5 commits March 12, 2025 13:33
@swolchok
Update
eabae64 
[ghstack-poisoned]
@swolchok
Update
046f5b6 
[ghstack-poisoned]
@swolchok
Update
062908f 
[ghstack-poisoned]
@swolchok
Update
18142d0 
[ghstack-poisoned]
@swolchok
Update
f6c43ff 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

noting CI is green before rebasing

swolchok added 7 commits March 12, 2025 16:20
@swolchok
Update
fc9caab 
[ghstack-poisoned]
@swolchok
Update
d2d3f61 
[ghstack-poisoned]
@swolchok
Update
824aebf 
[ghstack-poisoned]
@swolchok
Update
939aabd 
[ghstack-poisoned]
@swolchok
Update
0c6246b 
[ghstack-poisoned]
@swolchok
Update
605bfe7 
[ghstack-poisoned]
@swolchok
Update
26da460 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Mar 13, 2025
Merged
swolchok added 3 commits March 14, 2025 10:55
@swolchok
Update
b82c9a8 
[ghstack-poisoned]
@swolchok
Update
a2c5a30 
[ghstack-poisoned]
@swolchok
Update
70a47ff 
[ghstack-poisoned]
Base automatically changed from gh/swolchok/343/head to main March 14, 2025 21:27
@swolchok
Update
b734c85 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

noting CI is green before rebasing

merging based on previous green run

@swolchok swolchok merged commit fbed0b2 into main Mar 14, 2025
3 of 5 checks passed
@swolchok swolchok deleted the gh/swolchok/344/head branch March 14, 2025 21:29
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
@swolchok @DannyYuyang-quic
Skip grain_size computation in parallel_for_each_reduce_* wrappers wi…
8b61b6d 
…thout threadpool (pytorch#9144)

If we don't have the threadpool then this division is wasted.
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Skip grain_size computation in parallel_for_each_reduce_* wrappers wi…
28c054a 
…thout threadpool

If we don't have the threadpool then this division is wasted.

ghstack-source-id: 3202c7a
ghstack-comment-id: 2715052352
Pull Request resolved: pytorch/executorch#9144
swolchok added a commit that referenced this pull request Jul 22, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
d55575d 
ghstack-source-id: 8276173
ghstack-comment-id: 3104082224
Pull-Request: #12720
swolchok added a commit that referenced this pull request Jul 24, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
223eb8d 
ghstack-source-id: acb23c9
ghstack-comment-id: 3104082224
Pull-Request: #12720
swolchok added a commit that referenced this pull request Aug 11, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
2abf83f 
ghstack-source-id: 26d7e03
ghstack-comment-id: 3104082224
Pull-Request: #12720
swolchok added a commit that referenced this pull request Aug 11, 2025
@swolchok
Fix typo in reduce_util.h from my #9144 (#12720)
a84b3c9
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@swolchok @agrima1304
Fix typo in reduce_util.h from my pytorch#9144 (pytorch#12720)
89b714b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

+1 more reviewer

@mcr229 mcr229 mcr229 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swolchok @JacobSzwejbka @mcr229 @facebook-github-bot