Skip to content

Default ExecuTorch targets to ExecuTorch-wide Buck visibility #8969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Default ExecuTorch targets to ExecuTorch-wide Buck visibility #8969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions shim_et/xplat/executorch/build/runtime_wrapper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ def _patch_kwargs_common(kwargs):
for dep_type in ("deps", "exported_deps"):
env.patch_deps(kwargs, dep_type)

if "visibility" not in kwargs:
kwargs["visibility"] = ["//executorch/..."]

# Patch up references to "//executorch/..." in lists of build targets,
# if necessary.
use_static_deps = kwargs.pop("use_static_deps", False)
Expand All @@ -202,10 +205,6 @@ def _patch_kwargs_common(kwargs):
function = native.partial(_patch_executorch_references, use_static_deps = use_static_deps),
)

# Make all targets private by default, like in xplat.
if "visibility" not in kwargs:
kwargs["visibility"] = []

# If we see certain strings in the "visibility" list, expand them.
if "@EXECUTORCH_CLIENTS" in kwargs["visibility"]:
# See env.executorch_clients for this list.
Expand Down
Loading