Use CMake EXPORT #8954
Open
Use CMake EXPORT #8954
+495
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
dbort,
JacobSzwejbka,
lucylq,
manuelcandales,
kimishpatel,
shoumikhin,
jackzhxng,
iseeyuan,
larryliu0820,
digantdesai,
mcr229,
SS-JIA and
cccclai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8954
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit db7c3cd with merge base 8d57c95 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 5, 2025
The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: e3e5b36 ghstack-comment-id: 2699501745 Pull Request resolved: #8954
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 17, 2025
|
have an update cooking, need to make sure check whether warnings I'm seeing about macOS version mismatch during install_executorch.sh are new and if so problematic |
swolchok
added a commit
that referenced
this pull request
Jul 23, 2025
The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: f1615a2 ghstack-comment-id: 2699501745 Pull Request resolved: #8954
swolchok
commented
Jul 23, 2025
…t failure for the EXPORT PR [ghstack-poisoned]
…t failure for the EXPORT PR [ghstack-poisoned]
…t failure for the EXPORT PR [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 23, 2025
The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: efb6f61 ghstack-comment-id: 2699501745 Pull Request resolved: #8954
swolchok
requested review from
jathu
and removed request for
shoumikhin,
dbort,
iseeyuan,
jackzhxng and
mcr229
swolchok
requested review from
kirklandsign,
GregoryComer and
mergennachin
as code owners
|
This is getting very close to green CI if it's not there already, so marking ready for review. |
[ghstack-poisoned]
[ghstack-poisoned]
|
looks like ARM size tests need their bump increased and otherwise this looks very promising |
[ghstack-poisoned]
[ghstack-poisoned]
|
finally 100% green CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake EXPORT feature makes target_compile_options/target_link_libraries etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. We are currently working around our lack of EXPORT by (incompletely and therefore incorrectly!) repeating our configuration in tools/cmake/executorch-config.cmake.
I was previously stalled here by XNNPACK's lack of use of EXPORT, but I discovered that I simply wasn't being thorough enough with installing/exporting the entire target graph.
Note that this diff raises the size test thresholds. This is because previously the size test wasn't including prim op registration, and this diff effectively fixes builds using find_package to always include that.