Skip to content

Conversation

GregoryComer
Copy link
Member

Summary:
Add a preprocessor flag (ET_THREADPOOL_SIZE) and corresponding buck config ("executorch.threadpool_size") to set the default ET threadpool size.

The intent of this change is to allow users in very memory-constrained environments to opt in to a smaller threadpool to shave a small amount of additional memory. Even when measuring resident set size, the addition threads can add more than a Mb of peak memory.

I considered making this a parameter to get_threadpool, but it is not consistently usable, as it depends on who first instantiates the threadpool. As it's a shared resource, it seemed more prudent to make it a build-time configuration.

Differential Revision: D68401795

Copy link

pytorch-bot bot commented Jan 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7773

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7ab3449 with merge base fedb035 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68401795

@GregoryComer GregoryComer added topic: not user facing release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. topic: not user facing labels Jan 20, 2025
Summary:

Add a preprocessor flag (ET_THREADPOOL_SIZE) and corresponding buck config ("executorch.threadpool_size") to set the default ET threadpool size.

The intent of this change is to allow users in very memory-constrained environments to opt in to a smaller threadpool to shave a small amount of additional memory. Even when measuring resident set size, the addition threads can add more than a Mb of peak memory.

I considered making this a parameter to get_threadpool, but it is not consistently usable, as it depends on who first instantiates the threadpool. As it's a shared resource, it seemed more prudent to make it a build-time configuration.

Differential Revision: D68401795
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68401795

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. stale PRs inactive for over 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants