Add support for tuple as input type to delegate in emitter. #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There could be instances where the input to a delegate is a tuple in itself, this is no different from supporting a list type. Adding support for this in the emitter. Export also does this where it converts a tuple input to a op to a list input. Differential Revision: D49712806
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49712806 |
Contributor
|
This pull request has been merged in 06c7af5. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* implement --device 'fast' * land --device fast, but don't make it default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There could be instances where the input to a delegate is a tuple in itself, this is no different from supporting a list type. Adding support for this in the emitter. Export also does this where it converts a tuple input to a op to a list input.
Differential Revision: D49712806