Skip to content

Use python_binary and python_library from build wrappers in profiler targets #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions profiler/TARGETS
Original file line number Diff line number Diff line change
@@ -1,27 +1,28 @@
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain fbcode-only targets.

load("@fbcode_macros//build_defs:python_binary.bzl", "python_binary")
load("@fbcode_macros//build_defs:python_library.bzl", "python_library")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

python_library(
runtime.python_library(
name = "parse_profiler_library",
srcs = [
"parse_profiler_results.py",
"profiler_results_cli.py",
],
visibility = ["PUBLIC"],
visibility = ["@EXECUTORCH_CLIENTS"],
deps = [
"fbsource//third-party/pypi/prettytable:prettytable",
"//executorch/exir:schema",
"//executorch/exir/serialize:lib",
],
)

python_library(
runtime.python_library(
name = "profiler_results_scuba",
srcs = [
"profiler_results_scuba.py",
],
visibility = ["@EXECUTORCH_CLIENTS"],
deps = [
":parse_profiler_library",
"//executorch/exir:schema",
Expand All @@ -32,15 +33,22 @@ python_library(
],
)

python_binary(
name = "profiler_results_cli",
runtime.python_library(
name = "profiler_results_cli_lib",
srcs = [
"profiler_results_cli.py",
],
main_module = "executorch.profiler.profiler_results_cli",
deps = [
":parse_profiler_library",
":profiler_results_scuba",
"//executorch/exir/serialize:lib",
],
)

runtime.python_binary(
name = "profiler_results_cli",
main_module = "executorch.profiler.profiler_results_cli",
deps = [
":profiler_results_cli_lib",
],
)