Skip to content

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Nov 11, 2025

Reapply "Arm backend: Add pypi package install option for VGF backend" (#15681)

This reverts #15681.

Additionally update TARGETS in Arm backend in order to fix the internal errors mentioned in #15681.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 11, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15737

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Unrelated Failures

As of commit d563c28 with merge base 2aeee9b (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2025
@mansnils
Copy link
Collaborator Author

@SS-JIA I relanded / reverted the revert to restore the PR for now to test with if needed.
Note this PR has an additional update in backends/arm/TARGETS that should hopefully fix the internal errors.

@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this in D86793010.

Copy link
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal signals look good!

@zingo
Copy link
Collaborator

zingo commented Nov 12, 2025

Thanks, lets try again

@zingo zingo merged commit 6de1f4e into pytorch:main Nov 12, 2025
295 of 302 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants