Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

This PR supports whisper-large-{v2, v3, v3-turbo} on et-cuda backend, and update readme and ci.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15680

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Pending, 3 Unrelated Failures

As of commit 178ec40 with merge base 3dbc15b (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

*)
echo "Error: Unsupported model '$HF_MODEL'"
echo "Supported models: mistralai/Voxtral-Mini-3B-2507, openai/whisper-small, google/gemma-3-4b-it"
echo "Supported models: mistralai/Voxtral-Mini-3B-2507, openai/whisper-small, openai/whisper-large-v2, google/gemma-3-4b-it"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whisper-*?

Supported models:
- mistralai/Voxtral-Mini-3B-2507
- openai/whisper-small
- openai/whisper-large-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add large-v3-turbo in CI.

DEFINE_string(
model_name,
"base",
"Whisper model name (base, small, medium, large, large-v2, large-v3, turbo).");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

large-v3-turbo

static_cast<float>(
encoder_output_tensor
.mutable_data_ptr<::executorch::aten::BFloat16>()[0]));
.mutable_data_ptr<float>()[0]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where the encoder input == 0 came from.

PREPROCESSOR_OUTPUT="voxtral_preprocessor.pte"
;;
openai/whisper-small)
openai/whisper-*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREPROCESSOR_FEATURE_SIZE changes depending on the whisper model

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for pointed out! Fixeed it

@Gasoonjia Gasoonjia merged commit 8a8af36 into main Nov 7, 2025
308 of 312 checks passed
@Gasoonjia Gasoonjia deleted the large-whispers branch November 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants