Do not copy beyond out tensor bounds #15648
Merged
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15648
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 76104b3 with merge base 3dbc15b ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 6, 2025
Summary: `set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time. Add some checks to make sure we do not exceed the out tensor (out_data) size when copying. Differential Revision: D86436435
lucylq
force-pushed
the
export-D86436435
branch
2 times, most recently
from
18cf8e6 to
b6ba8eb
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 6, 2025
Summary: `set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time. Add some checks to make sure we do not exceed the out tensor (out_data) size when copying. Differential Revision: D86436435
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 7, 2025
Summary: `set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time. Add some checks to make sure we do not exceed the out tensor (out_data) size when copying. Differential Revision: D86436435
lucylq
force-pushed
the
export-D86436435
branch
from
b6ba8eb to
4f130cd
Compare
JacobSzwejbka
approved these changes
Nov 7, 2025
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 7, 2025
Summary: `set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time. Add some checks to make sure we do not exceed the out tensor (out_data) size when copying. Reviewed By: JacobSzwejbka Differential Revision: D86436435
lucylq
force-pushed
the
export-D86436435
branch
from
4f130cd to
06c0f0c
Compare
Summary: `set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time. Add some checks to make sure we do not exceed the out tensor (out_data) size when copying. Reviewed By: JacobSzwejbka Differential Revision: D86436435
lucylq
force-pushed
the
export-D86436435
branch
from
06c0f0c to
76104b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
set_all_to_value(out_data, out_step_len, value)loops over the padding and copies a row at a time.Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.
Differential Revision: D86436435