-
Notifications
You must be signed in to change notification settings - Fork 713
Pin huggingface_hub<1.0 #15399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin huggingface_hub<1.0 #15399
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15399
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 3 Pending, 3 Unrelated FailuresAs of commit e774959 with merge base cd6f2e2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Note that unit test ci failures are preexisting (getting to this next). Model test failure is a flake and I can't rerun until the whole pull job finishes. I'd like to land this one the relevant ci jobs pass to unbreak ci. |
### Summary We need to pin huggingface_hub in CI to avoid an incompatibility with our pinned version of transformers. See #15399 for more context - I missed a few places on trunk jobs. Cleaning these up here. ### Test Plan Running with ciflow/trunk. I verified that the test-huggingface-transformers-macos / * and gemma3-4b macos jobs pass on this PR. They are failing on trunk (see https://hud.pytorch.org/pytorch/executorch/commit/4c30da308ee811bdfa44fd4bea3bc439bfd303d4 for an example).
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Cherry picking #15399Command Details for Dev Infra teamRaised by workflow job |
Trying to fix failing HF CI jobs. Looks like our transformers version requires huggingface_hub<1.0, but we're installing the latest 1.0 version which just released today. Until we bump transformers, I'll just pin our install of huggingface_hub to below 1.0. Note that we don't pin the transformers version the same way for pip install, so this should be a ci only issue (and hence ci only fix). Here's an example job failure: ``` transformers 4.56.1 requires huggingface-hub<1.0,>=0.34.0, but you have huggingface-hub 1.0.0 which is incompatible. ... /exec: line 13: huggingface-cli: command not found ``` (from https://github.com/pytorch/executorch/actions/runs/18851188516/job/53787937311) (cherry picked from commit 57f0dfd)
We need to pin huggingface_hub in CI to avoid an incompatibility with our pinned version of transformers. See pytorch#15399 for more context - I missed a few places on trunk jobs. Cleaning these up here. Running with ciflow/trunk. I verified that the test-huggingface-transformers-macos / * and gemma3-4b macos jobs pass on this PR. They are failing on trunk (see https://hud.pytorch.org/pytorch/executorch/commit/4c30da308ee811bdfa44fd4bea3bc439bfd303d4 for an example).
Summary
Trying to fix failing HF CI jobs. Looks like our transformers version requires huggingface_hub<1.0, but we're installing the latest 1.0 version which just released today. Until we bump transformers, I'll just pin our install of huggingface_hub to below 1.0.
Note that we don't pin the transformers version the same way for pip install, so this should be a ci only issue (and hence ci only fix).
Here's an example job failure:
(from https://github.com/pytorch/executorch/actions/runs/18851188516/job/53787937311)