Skip to content

Arm backend: Refactor compile spec handling #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zingo merged 1 commit into from
Sep 9, 2025
Merged

Arm backend: Refactor compile spec handling #14111

zingo merged 1 commit into from
Sep 9, 2025

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Sep 9, 2025 •
edited by pytorch-bot bot
Loading

Instead of factories to create list[CompileSpec], use a dataclass that contains all specs directly. This cleans up the API for creating CompileSpecs and aligns it with how the partitioner and quantizer is designed. Keep compile spec in easily handled ArmCompileSpec format as long as possible, only go to list[CompileSpec] format when neccessary for the backend API. ArmCompileSpec is subclassed for each backend to minimize risk of using incorrect compile spec for a specific target.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) release notes: arm Changes to the ARM backend delegate labels Sep 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14111

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 89e07db with merge base 245630a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@zingo zingo added this to the 1.0.0 milestone Sep 9, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 9, 2025

test fails are unrelated

@zingo
Copy link
Collaborator

zingo commented Sep 9, 2025

@Erik-Lundell this seem to need a rebase :( Sorry about that.

@Erik-Lundell
Arm backend: Refactor compile spec handling
89e07db 
Keep compile spec in easily handled ArmCompileSpec format
as long as possible, only go to list[CompileSpec] format when
neccessary for the backend API. ArmCompileSpec is subclassed
for each backend to minimize risk of using incorrect compile spec
for a specific target.

TODO: go back to ArmCompileSpec format in our backend classes.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I90f6e7bc8cbfd5d248da728f401c8ae1fc116dab
@zingo zingo merged commit 29cec35 into pytorch:main Sep 9, 2025
451 checks passed
@Erik-Lundell Erik-Lundell deleted the compile-spec branch September 10, 2025 06:52
swolchok
swolchok reviewed Sep 10, 2025
View reviewed changes
backends/arm/arm_backend.py
@@ -1,245 +0,0 @@
# Copyright 2023-2025 Arm Limited and/or its affiliates.
Copy link
Contributor

@swolchok swolchok Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buck files need to be updated to reflect this deletion.

Copy link
Contributor

@swolchok swolchok Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are also references in docs/

This was referenced Sep 10, 2025
Merged
Merged
swolchok added a commit that referenced this pull request Sep 10, 2025
@swolchok
Revert "Arm backend: Refactor compile spec handling (#14111)"
dc23b0b 
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)


ghstack-source-id: 0688ea4
ghstack-comment-id: 3276337046
Pull-Request: #14175
swolchok added a commit that referenced this pull request Sep 10, 2025
@swolchok
Revert "Arm backend: Add --enable_debug_mode to AOT compiler (#14145)" (
5d63bad 
#14174)

This reverts commit 8c51641. Trying to
revert #14111 and this has conflicts.
swolchok added a commit that referenced this pull request Sep 10, 2025
@swolchok
Revert "Arm backend: Refactor compile spec handling (#14111)"
939638c 
This reverts commit 29cec35. This broke our internal Buck builds and I think revert/reapply will allow us to ingest changes faster overall. (Have plans to get some Buck coverage in GitHub CI that will prevent problems like this going forward soon.)


ghstack-source-id: ee95d6e
ghstack-comment-id: 3276337046
Pull-Request: #14175
swolchok added a commit that referenced this pull request Sep 11, 2025
@swolchok
Revert "Arm backend: Refactor compile spec handling (#14111)" (#14175)
f294074 
This reverts commit 29cec35. This broke
our internal Buck builds and I think revert/reapply will allow us to
ingest changes faster overall. (Have plans to get some Buck coverage in
GitHub CI that will prevent problems like this going forward soon.)
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2)
2d006c7 
Summary: Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
@mergennachin mergennachin mentioned this pull request Sep 11, 2025
Merged
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
dcd46a8 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
8a9cf5e 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
2cb36eb 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
50aa04a 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
e5397b5 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
e221b8d 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
67e8585 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
6c89cbe 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
d9493ff 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 11, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
861e98a 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193
mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request Sep 12, 2025
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2)
4b081fe 
Summary: Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193
mergennachin added a commit that referenced this pull request Sep 12, 2025
@mergennachin
Arm backend: Refactor compile spec handling (Try 2) (#14191)
8da4a6e 
Summary: Redoing #14111 with
additional fixes

Differential Revision: D82171193


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@swolchok @StrycekSimon
Revert "Arm backend: Add --enable_debug_mode to AOT compiler (pytorch…
282e83d 
…#14145)" (pytorch#14174)

This reverts commit 8c51641. Trying to
revert pytorch#14111 and this has conflicts.
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@swolchok @StrycekSimon
Revert "Arm backend: Refactor compile spec handling (pytorch#14111)" (p…
fcb1d58 
…ytorch#14175)

This reverts commit 29cec35. This broke
our internal Buck builds and I think revert/reapply will allow us to
ingest changes faster overall. (Have plans to get some Buck coverage in
GitHub CI that will prevent problems like this going forward soon.)
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@mergennachin @StrycekSimon
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
2087667 
Summary: Redoing pytorch#14111 with
additional fixes

Differential Revision: D82171193


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

+1 more reviewer

@swolchok swolchok swolchok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Erik-Lundell @zingo @swolchok