move codegen pybindings out of public pybindings lib #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
cd29790 to
215110e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
215110e to
dd9483c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
dd9483c to
429bb19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
429bb19 to
c680116
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
c680116 to
b4c3b10
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
b4c3b10 to
74e9313
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
74e9313 to
067fafd
Compare
Summary: Pull Request resolved: pytorch/executorch#131 These are only used by codegen. Moving them out of the general pybindings lib and restricting visibility. As a side note I dont think any of this stuff actually has to happen in c++. In fact it seems like itd be easier to do this on the Python Version of the schema object through deserialize_for_json. Reviewed By: larryliu0820, dbort Differential Revision: D48671946 fbshipit-source-id: 96891e2be24e9dbce609c35b19bf855da5a72f0b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48671946 |
JacobSzwejbka
force-pushed
the
export-D48671946
branch
from
067fafd to
7c50da7
Compare
Contributor
|
This pull request has been merged in ae8c6d9. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
May 14, 2025
…3-full to main-nxp Merge in AITEC/executorch from EIEX-258-cherry-pick-from-release-mcux-25.03-full-to-main-nxp to main-nxp * commit 'eac3cd2a3095c156a65fd84c10b7eee23b3e5347': Make the KWS model working on RT700. Add User Guide about ExecuTorch example Fix headers for OSS repo Change header to BSD license (pytorch#8428) Add NXP copyright and BSD license Update Neutron software to v1.2.0+0X1b86b19d Install examples/nxp/cifarnet as part of the executorch Change LA_OPT_NXP_Software_License to BSD-3 and add Apache 2.0 license Correct NXP License
kimishpatel
added a commit
that referenced
this pull request
Nov 6, 2025
Without this fix when running diabled tets it fails with OMP: Error #131: Thread identifier invalid Differential Revision: [D86447540](https://our.internmc.facebook.com/intern/diff/D86447540/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Nov 10, 2025
…ed sdpa test" Without this fix when running diabled tets it fails with OMP: Error #131: Thread identifier invalid Differential Revision: [D86447540](https://our.internmc.facebook.com/intern/diff/D86447540/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Nov 10, 2025
Without this fix when running diabled tets it fails with OMP: Error #131: Thread identifier invalid Differential Revision: [D86447540](https://our.internmc.facebook.com/intern/diff/D86447540/) [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Nov 14, 2025
Without this fix when running diabled tets it fails with OMP: Error #131: Thread identifier invalid Differential Revision: [D86447540](https://our.internmc.facebook.com/intern/diff/D86447540/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These are only used by codegen. Moving them out of the general pybindings lib and restricting visibility.
As a side note I dont think any of this stuff actually has to happen in c++. In fact it seems like itd be easier to do this on the Python Version of the schema object through deserialize_for_json.
Differential Revision: D48671946