Skip to content

[ET-VK][Ops] common test utils for converting aten types to vulkan types #11575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2025

Conversation

ahmtox
Copy link
Contributor

@ahmtox ahmtox commented Jun 11, 2025

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

[ghstack-poisoned]
@ahmtox ahmtox requested a review from SS-JIA as a code owner June 11, 2025 21:48
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jun 11, 2025
Copy link

pytorch-bot bot commented Jun 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11575

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit c34ed3c with merge base 8cfa858 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

…o vulkan types"

most custom ops utilize some aten to executorch scalartype conversion. this test file standardized that across those files

Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)

cc SS-JIA manuelcandales cbilgin

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76464550

@facebook-github-bot facebook-github-bot merged commit e60f17a into gh/ahmtox/23/base Jun 14, 2025
93 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/ahmtox/23/head branch June 14, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants