[ET-VK][Ops] dequantization op shaders and impl #11483

ahmtox · 2025-06-09T15:05:04Z

Stack from ghstack (oldest at bottom):

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework.

Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

pytorch-bot · 2025-06-09T15:05:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11483

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f941d41 with merge base 3b1c7fd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) ghstack-source-id: 289116371 Pull Request resolved: #11483

facebook-github-bot · 2025-06-09T15:06:55Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

Pull Request resolved: #11483 Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. ghstack-source-id: 289118183 @exported-using-ghexport Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/)

facebook-github-bot · 2025-06-09T15:10:44Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T17:02:26Z

This pull request was exported from Phabricator. Differential Revision: D76267107

manuelcandales · 2025-06-11T18:45:51Z

backends/vulkan/test/op_tests/dequantize_test.cpp

@@ -749,14 +753,40 @@ TEST(

 TEST(
    VulkanDequantizePerTensorTest,
-    test_reference_dequantize_per_tensor_int16_to_float) {


why did you delete this int16 test?

I deleted int16 because it's not included as a variant in the yaml. I'll remove this from the origin commit. I'm trying to only support variants that would seemingly be used, which I think would be uint8, int8, and int32

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T19:02:02Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T21:51:09Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T14:53:09Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T17:01:25Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T17:05:50Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T19:51:53Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T04:15:50Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T15:15:53Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T18:05:16Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T22:51:50Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-16T22:27:22Z

This pull request was exported from Phabricator. Differential Revision: D76267107

Creating the dequantize_per_tensor and dequantize_per_token logic shaders and impl which are linked with the testing framework. Differential Revision: [D76267107](https://our.internmc.facebook.com/intern/diff/D76267107/) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T17:07:15Z

This pull request was exported from Phabricator. Differential Revision: D76267107

ahmtox requested a review from SS-JIA as a code owner June 9, 2025 15:05

This was referenced Jun 9, 2025

[ET] enabling half dtype input for quantization #11479

Merged

[ET-VK] double, short, and uint16 dtype runtime support #11365

Merged

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025

facebook-github-bot added the fb-exported label Jun 9, 2025

manuelcandales reviewed Jun 11, 2025

View reviewed changes

ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025

ahmtox mentioned this pull request Jun 11, 2025

[ET-VK][Ops] common test utils for converting aten types to vulkan types #11575

Merged

manuelcandales approved these changes Jun 12, 2025

View reviewed changes

facebook-github-bot merged commit db00b95 into gh/ahmtox/16/base Jun 17, 2025
96 of 98 checks passed

facebook-github-bot deleted the gh/ahmtox/16/head branch June 17, 2025 22:03

facebook-github-bot temporarily deployed to cherry-pick-bot June 17, 2025 22:03 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jun 17, 2025

[ET-VK][Ops] dequantization op shaders and impl #11768

Merged

[ET-VK][Ops] dequantization op shaders and impl #11483

[ET-VK][Ops] dequantization op shaders and impl #11483

Uh oh!

Conversation

ahmtox commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11483

✅ No Failures

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

manuelcandales Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

ahmtox Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 16, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

ahmtox commented Jun 9, 2025 •

edited

Loading

pytorch-bot bot commented Jun 9, 2025 •

edited

Loading