Skip to content

[ET-VK] Minor tuning for conv2d pw op to improve performance. #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged

[ET-VK] Minor tuning for conv2d pw op to improve performance. #11113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79d658f
[ET-VK] Minor tuning for conv2d pw op to improve performance.
trivedivivek May 23, 2025
c3a99c6
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 27, 2025
dc79693
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 27, 2025
9de3b16
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 27, 2025
f64e854
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 28, 2025
4139561
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 28, 2025
4f9e963
Update on "[ET-VK] Minor tuning for conv2d pw op to improve performan…
trivedivivek May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backends/vulkan/runtime/graph/ops/glsl/conv2d_pw.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ void main() {
const uint div_by_x = gl_GlobalInvocationID.x / out_limits_scaled.x;
const ivec3 gpos = ivec3(
gl_GlobalInvocationID.x % out_limits_scaled.x,
div_by_x % out_limits_scaled.y,
div_by_x / out_limits_scaled.y);
div_by_x,
gl_GlobalInvocationID.y);

// If the top left position is out of bounds, then this invocation will have
// no work to do.
if (gpos.z >= out_limits.z) {
if (gpos.y >= out_limits_scaled.y || gpos.z >= out_limits.z) {
return;
}

Expand Down
4 changes: 3 additions & 1 deletion backends/vulkan/runtime/graph/ops/impl/Convolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,10 @@ void add_conv2d_node(
utils::uvec3 wg_size = create_conv2d_global_wg_size(
graph, method, out, weight_data, stride_equals_dilation);

if (method == Conv2dMethod::Pointwise || method == Conv2dMethod::Depthwise) {
if (method == Conv2dMethod::Depthwise) {
wg_size = {wg_size[0] * wg_size[1] * wg_size[2], 1, 1};
} else if (method == Conv2dMethod::Pointwise) {
wg_size = {wg_size[0] * wg_size[1], wg_size[2], 1};
}

vkapi::ParamsBindList param_buffers;
Expand Down
Loading