Skip to content

Conversation

SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented May 8, 2025

Summary

Refactoring of unit tests to allow for testing of TOSA 1.0
Adds command-line argument --arm_run_tosa_version to run tests on particular version

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

SaoirseARM added 5 commits May 8, 2025 13:58
- Adds command line --arm_run_tosa_version

Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: I3337ad39192ec15fbb27610c73d282cc19a98d38
Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: Id89019818ba4f447daf849b5e14debee0b16d0f9
Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: Iccc30f84626a6d32dfe92fbf41ed500e2249bb4d
Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: I7a1896ba1d40d2bd0e313da0c33ff21ed8c0738c
Change-Id: Ieb0e0104a9ebc15f319453f983edfaf0016d4050
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10776

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit 894258c with merge base d9c6f80 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 8, 2025
@zingo
Copy link
Collaborator

zingo commented May 8, 2025

Fails are unrelated

if config.option.arm_run_tosa_version:
pytest._test_options["tosa_version"] = config.option.arm_run_tosa_version

pytest._test_options["tosa_ref_model"] = True # type: ignore[attr-defined]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is BC breaking. I will try to forward fix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Digant!

jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
### Summary
Refactoring of unit tests to allow for testing of TOSA 1.0
Adds command-line argument --arm_run_tosa_version to run tests on
particular version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants