Skip to content

[ET-VK][ez] Use standard quant naming scheme for quantized ops #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10587 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/221/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/221/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/221/orig
@diff-train-skip-merge

Pull Request resolved: #10587

## Context

Use standard naming scheme for quantized operators introduced in the previous PR.

For weight only quantized linear operators, the names introduced are:

`linear_qcsnw`:

* q - quantized
* c - per-channel / channelswise
* s - symmetric
* n - number of bits (qcs4w for 4-bit quant, qcs8w for 8-bit quant)
* w - weight quantized

`linear_qga4w`:

* q - quantized
* g - per-group / groupwise
* a - affine
* 4 - quantized to 4 bits
* w - weight quantized

## Changes

Rename instances of `q_8w_linear` to `linear_qcs8w` or `linear_qcsnw`.

Rename instances of `q_4w_linear` to `linear_qga4w`.

Rename cpp files to match the new naming convention.
ghstack-source-id: 281447659
@exported-using-ghexport

Differential Revision: [D73941992](https://our.internmc.facebook.com/intern/diff/D73941992/)
@pytorchbot pytorchbot requested a review from SS-JIA as a code owner May 1, 2025 18:17
Copy link

pytorch-bot bot commented May 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10616

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2025
@SS-JIA SS-JIA added the release notes: vulkan Changes to the Vulkan backend delegate label May 1, 2025
@SS-JIA SS-JIA merged commit bdca6e3 into main May 1, 2025
82 of 84 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/221/orig branch May 1, 2025 18:21
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
…ch#10616)

## Context

Use standard naming scheme for quantized operators introduced in the previous PR.

For weight only quantized linear operators, the names introduced are:

`linear_qcsnw`:

* q - quantized
* c - per-channel / channelswise
* s - symmetric
* n - number of bits (qcs4w for 4-bit quant, qcs8w for 8-bit quant)
* w - weight quantized

`linear_qga4w`:

* q - quantized
* g - per-group / groupwise
* a - affine
* 4 - quantized to 4 bits
* w - weight quantized

## Changes

Rename instances of `q_8w_linear` to `linear_qcs8w` or `linear_qcsnw`.

Rename instances of `q_4w_linear` to `linear_qga4w`.

Rename cpp files to match the new naming convention.

Differential Revision: [D73941992](https://our.internmc.facebook.com/intern/diff/D73941992/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants