[ET-VK][ez] Enable Vulkan tests to build for Android in OSS + misc fixes #10368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10368
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit 52390a7 with merge base b52ad91 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary:
## Changes
Modified the `CMakeLists.txt` of test targets to be able to build for Android.
Apply SPIR-V optimization when building Vulkan compute shaders.
Test Plan:
## Test Plan
Built and ran test binaries on local Android device.
After installing main ET C++ libs for Android...
Build compute_api_test binary.
```
pp cmake backends/vulkan/test \
-DCMAKE_INSTALL_PREFIX=cmake-android-out \
-DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK/build/cmake/android.toolchain.cmake \
-DANDROID_ABI=arm64-v8a \
-DANDROID_PLATFORM=android-28 \
-DPYTHON_EXECUTABLE=python \
-DCMAKE_BUILD_TYPE=Release \
-Bcmake-android-out/backends/vulkan/test && \
cmake --build cmake-android-out/backends/vulkan/test -j16 --config Release
```
Push and run on device:
```
adb -s $IP push cmake-android-out/backends/vulkan/test/vulkan_compute_api_test /data/local/tmp/test_bin && \
adb -s $IP shell /data/local/tmp/test_bin \
--gtest_filter="*add*"
```
Build the operator test binaries:
```
rm -rf cmake-out/backends/vulkan/test/op_tests && \
pp cmake backends/vulkan/test/op_tests \
-DCMAKE_INSTALL_PREFIX=cmake-android-out \
-DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK/build/cmake/android.toolchain.cmake \
-DANDROID_ABI=arm64-v8a \
-DANDROID_PLATFORM=android-28 \
-DPYTHON_EXECUTABLE=python \
-DCMAKE_BUILD_TYPE=Release \
-DTORCH_OPS_YAML_PATH=/home/ssjia/Github/pytorch/aten/src/ATen/native \
-DTORCH_INSTALL_PREFIX=/home/ssjia/Github/pytorch/build_android \
-Bcmake-android-out/backends/vulkan/test/op_tests && \
cmake --build cmake-android-out/backends/vulkan/test/op_tests -j16 --config Release
```
Push and run on device. Note that these binaries require `libtorch` so files to be pushed to the device as well.
```
# Push torch libs
adb -s $IP push /home/ssjia/Github/pytorch/build_android/lib/libtorch.so /data/local/tmp/ && \
adb -s $IP push /home/ssjia/Github/pytorch/build_android/lib/libtorch_cpu.so /data/local/tmp/ && \
adb -s $IP push /home/ssjia/Github/pytorch/build_android/lib/libc10.so /data/local/tmp/ && \
adb push $ANDROID_NDK/toolchains/llvm/prebuilt/linux-x86_64/lib/clang/18/lib/linux/aarch64/libomp.so /data/local/tmp/libomp.so
adb -s $IP push cmake-android-out/backends/vulkan/test/op_tests/vulkan_linear_weight_int4_test /data/local/tmp/test_bin && \
adb -s $IP shell LD_LIBRARY_PATH=/data/local/tmp /data/local/tmp/test_bin
```
kirklandsign
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
Modified the
CMakeLists.txtof test targets to be able to build for Android.Apply SPIR-V optimization when building Vulkan compute shaders.
Test Plan:
Test Plan
Built and ran test binaries on local Android device.
After installing main ET C++ libs for Android...
Build compute_api_test binary.
Push and run on device:
Build the operator test binaries:
Push and run on device. Note that these binaries require
libtorchso files to be pushed to the device as well.