-
Notifications
You must be signed in to change notification settings - Fork 634
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixmodule: benchmarkIssues related to the benchmark infrastructureIssues related to the benchmark infrastructuremodule: user experienceIssues related to reducing friction for usersIssues related to reducing friction for userstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
As shown in an example run, there are two issues that make it difficult to understand the expected behavior and locate the exact error:
- Unexpected job success status: Two configurations failed to export, yet the
benchmark-on-device
jobs were still marked as successful (highlighted in the red box). The expected behavior is thatbenchmark-on-device
jobs should either not be scheduled or be marked as skipped/canceled if a dependent job, such as export, fails. - In the
export-models
job, the error in "Upload artifacts to S3" step is misleading. It should be marked as skipped or canceled, as the "Run script in the container" step failed to generate the .pte file (highlighted in the yellow box).
cc: @huydhn @cbilgin @digantdesai @kimishpatel
Versions
trunk
Metadata
Metadata
Assignees
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixmodule: benchmarkIssues related to the benchmark infrastructureIssues related to the benchmark infrastructuremodule: user experienceIssues related to reducing friction for usersIssues related to reducing friction for userstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
Done
Status
Done
Status
Done