Add logging to ImageNet training #530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 18, 2019 09:01
This reverts commit 847cd87.
|
I think for a base example, adding specialized logging is a bit of an overkill. My main hesitation is to increase the line count of the file over something that's not very important for an example script. It makes more sense in something like torchvision reference scripts though: pytorch/vision#819 |
|
With the new reference scripts (which were comitted after I created this PR) you are indeed correct. I will open a new PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logging to the console and a log file. For now the logger is configured to log infos to
stdoutand everything with a higher level tostderr. Furthermore each record shows the time and level in addition to the message.