Reorganize Captum Insights code #400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
insights-clean
branch
from
af04138 to
8ec7c33
Compare
J0Nreynolds
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
If there are any major functionality changes, please let me know, but from glancing at this, it looks like this diff is mostly code separation. I think the code has been separated appropriately, and it should make it easier to work with and digest the JS code.
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
insights-clean
branch
from
8ec7c33 to
c89ec36
Compare
|
@edward-io merged this pull request in 0f569f2. |
p16i
pushed a commit
to p16i/captum
that referenced
this pull request
Jun 20, 2020
Summary: Some housekeeping to prepare for future changes. - Separate out React components into individual files - Switch from class based to function based components - Fix accessibility lint To test: Build the frontend code and use the Insights example. Additionally test using notebook. Pull Request resolved: pytorch#400 Differential Revision: D21969379 Pulled By: edward-io fbshipit-source-id: c8632359877df39a373b20bda2a03a3241163275
edward-io
added a commit
to edward-io/captum
that referenced
this pull request
Jun 30, 2020
Summary: Some housekeeping to prepare for future changes. - Separate out React components into individual files - Switch from class based to function based components - Fix accessibility lint To test: Build the frontend code and use the Insights example. Additionally test using notebook. Pull Request resolved: pytorch#400 Differential Revision: D21969379 Pulled By: edward-io fbshipit-source-id: c8632359877df39a373b20bda2a03a3241163275
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: Some housekeeping to prepare for future changes. - Separate out React components into individual files - Switch from class based to function based components - Fix accessibility lint To test: Build the frontend code and use the Insights example. Additionally test using notebook. Pull Request resolved: pytorch#400 Differential Revision: D21969379 Pulled By: edward-io fbshipit-source-id: c8632359877df39a373b20bda2a03a3241163275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some housekeeping to prepare for future changes.
To test:
Build the frontend code and use the Insights example. Additionally test using notebook.