Separate out future logic from attribute method into attribute_future in Feature Ablation #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
jjuncho
added a commit
that referenced
this pull request
Aug 9, 2024
… in Feature Ablation (#1320) Summary: Pull Request resolved: #1320 This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods. the construct_future_forward helper method was also moved into the utils class to share with other method tests Differential Revision: D60911353
jjuncho
force-pushed
the
export-D60911353
branch
from
8c7083f to
d9619f7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
… in Feature Ablation (#1320) Summary: This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods. the construct_future_forward helper method was also moved into the utils class to share with other method tests Differential Revision: D60911353
facebook-github-bot
force-pushed
the
export-D60911353
branch
from
d9619f7 to
e6c8bbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
… in Feature Ablation (#1320) Summary: This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods. the construct_future_forward helper method was also moved into the utils class to share with other method tests Reviewed By: yucu Differential Revision: D60911353
facebook-github-bot
force-pushed
the
export-D60911353
branch
from
e6c8bbc to
ed114f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
… in Feature Ablation (#1320) Summary: This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods. the construct_future_forward helper method was also moved into the utils class to share with other method tests Reviewed By: yucu Differential Revision: D60911353
facebook-github-bot
force-pushed
the
export-D60911353
branch
from
ed114f7 to
f5d9053
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
… in Feature Ablation (#1320) Summary: Pull Request resolved: #1320 This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods. the construct_future_forward helper method was also moved into the utils class to share with other method tests Reviewed By: yucu Differential Revision: D60911353
|
This pull request was exported from Phabricator. Differential Revision: D60911353 |
jjuncho
force-pushed
the
export-D60911353
branch
from
f5d9053 to
fa2c11a
Compare
|
This pull request has been merged in 5ffd68a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff separates the logic for futures in the FeatureAblation class into its own method, attribute_future. This method should only be used with forward functions that return a future, and additional test cases were added to ensure the proper usage of the attribute and the attribute_future methods.
the construct_future_forward helper method was also moved into the utils class to share with other method tests
Differential Revision: D60911353