Fix module name extraction logic in quant_api.py #3298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3298
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4e382e2 with merge base 6815e57 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jcaip
added
topic: bug fix
jerryzh168
approved these changes
Nov 6, 2025
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
lg if it doesn't break the module parameters path
jerryzh168
reviewed
Nov 6, 2025
Comment on lines
+1141
to
+1142
| "nested.linear": Int8WeightOnlyConfig(), | ||
| "linear1": Int8WeightOnlyConfig(), |
Contributor
There was a problem hiding this comment.
nit: use new tensors, e.g. Int4WeightOnlyConfig (with Int4Tensor), since we are moving away from AQT
Contributor
Author
There was a problem hiding this comment.
oh sorry didn't see this - let me update all of the configs in the tests
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
* remove module_name splitting * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att