Revert D82355346 #3132
Merged
Revert D82355346 #3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff reverts D82355346 This diff break the cache hits for PT2 cache, as result, we saw a jump in PT2 compilation time Depends on D82355346 Reviewed By: HugeEngine Differential Revision: D84169566
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3132
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 62a2e61 with merge base 2d31ac3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@Mingming-Ding has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84169566. |
jerryzh168
previously approved these changes
Oct 8, 2025
pytorch-bot
bot
dismissed
jerryzh168’s stale review
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
seemethere
approved these changes
Oct 8, 2025
jerryzh168
approved these changes
Oct 8, 2025
jerryzh168
added
the
topic: not user facing
atalman
approved these changes
Oct 8, 2025
oulgen
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reverts D82355346
This diff break the cache hits for PT2 cache, as result, we saw a jump in PT2 compilation time
Depends on D82355346
Reviewed By: HugeEngine
Differential Revision: D84169566