Skip to content

Conversation

@petrex
Copy link
Collaborator

@petrex petrex commented Aug 21, 2025

This pull request introduces a conditional inclusion of the tensor_core_tiled_layout source directory for ROCm builds in setup.py. This change ensures that the tiled layout extension is only included when supported, improving build correctness and maintainability.

Note that there is a regression on ROCm 7.0 to build this kernel.

Conditional ROCm source inclusion:

  • Added a new rocm_tiled_layout_supported flag to control whether the tensor_core_tiled_layout source directory is included for ROCm extensions. (setup.py)
  • Modified the logic for assembling rocm_source_dirs so that tensor_core_tiled_layout is only appended if rocm_tiled_layout_supported is True. (setup.py)

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2839

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4eb0357 with merge base abffabb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
@petrex petrex added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 21, 2025
@petrex petrex merged commit d321a2c into pytorch:main Aug 26, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant