Conditional ROCm kernel build #2839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a conditional inclusion of the
tensor_core_tiled_layoutsource directory for ROCm builds insetup.py. This change ensures that the tiled layout extension is only included when supported, improving build correctness and maintainability.Note that there is a regression on ROCm 7.0 to build this kernel.
Conditional ROCm source inclusion:
rocm_tiled_layout_supportedflag to control whether thetensor_core_tiled_layoutsource directory is included for ROCm extensions. (setup.py)rocm_source_dirsso thattensor_core_tiled_layoutis only appended ifrocm_tiled_layout_supportedisTrue. (setup.py)