Update benchmarking tool to run on local iPhones #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff allows us to benchmark models on local iphones. Since end of benchmarking cannot be reliably identified using `idb` commands, created `BENCH_DONE` file at the end of benchmark (as part of destructor method) to detect the end of benchmarking. Reviewed By: kushrast Differential Revision: D80095129
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2775
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c0a3240 with merge base 2eae09b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80095129 |
navsud
added
the
topic: not user facing
kimishpatel
approved these changes
Aug 15, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Differential Revision: D80095129 Pull Request resolved: #2775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff allows us to benchmark models on local iphones.
Since end of benchmarking cannot be reliably identified using
idbcommands, createdBENCH_DONEfile at the end of benchmark (as part of destructor method) to detect the end of benchmarking.Reviewed By: kushrast
Differential Revision: D80095129