Fix setup develop #2748
Fix setup develop #2748
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2748
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit d694f32 with merge base 758f744 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
metascroy
added
the
topic: not user facing
swolchok
left a comment
swolchok
left a comment
There was a problem hiding this comment.
Python extensions always look for so files with specific names.
I was skeptical of this, but sure enough .so is the more popular extension in my site-packages directory. No complaints from my end but would like to give @drisspg a chance to review.
torchao/experimental/op_lib.py
Outdated
|
|
||
|
|
||
| def find_and_load_libtorchao_ops(potential_paths): | ||
| # import torchao._experimental_aten_ops |
drisspg
left a comment
drisspg
left a comment
There was a problem hiding this comment.
I think this is fine, is there any doc on libs are searched and this name schema you mention?
metascroy
force-pushed
the
fix-setup-develop
branch
from
954bf9a to
d694f32
Compare
Added docstring to op load function, but this is not user-facing. It is called inside torchao's init.py automatically. |
* Fix setup.py develop workflow * up * up
This enables you to run the following on macOS:
Python extensions always look for so files with specific names.