Skip to content

Backwards compatibility for TRT 7.x #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Conversation

borisfom
Copy link
Collaborator

@borisfom borisfom commented Aug 14, 2021

Signed-off-by: Boris Fomitchev [email protected]

Description

Works for 21.06 and 21.07 Pytorch containers now - I have added Dockerfiles and remove old ones.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@borisfom
Copy link
Collaborator Author

borisfom commented Aug 15, 2021

With the latest changes, TRTorch compiles with both TRT7 and TRT8.
Also, there were further API changes in TRT 1.10 to preprocess function signature (parameter added), so I added one to ours.
The code now fully builds in Pytorch 21.07 and 21.06 containers.

Signed-off-by: Boris Fomitchev <[email protected]>
Signed-off-by: Boris Fomitchev <[email protected]>
@narendasan
Copy link
Collaborator

@borisfom can you rebase this branch on master? there seems to be a bunch of missing changes in runtime which will need the same sort of make_trt call https://github.com/NVIDIA/TRTorch/blob/master/core/runtime/TRTEngine.cpp

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan mentioned this pull request Aug 20, 2021
6 tasks
@narendasan narendasan merged commit b91c268 into pytorch:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants