-
Notifications
You must be signed in to change notification settings - Fork 364
Add instance norm #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instance norm #573
Conversation
dcc289e
to
fd787e0
Compare
@narendasan passed DCO |
@zsef123 Thanks for the contribution! Can you rebase your branch? Changes look mostly fine, once you rebase, I will run the tests and we should be good to go |
Signed-off-by: AhnDW <[email protected]>
fd787e0
to
16c78e9
Compare
Checked!! |
Signed-off-by: AhnDW <[email protected]>
4edc74a
to
31d3b90
Compare
I am getting test failures for Converters.ATenInstanceNormRunningStatsConvertsCorrectly where the TRT implementation returns NaN. Using TRT8 |
Signed-off-by: AhnDW <[email protected]>
@narendasan Sorry for missed. Several problems were mixed. All of them were test cases.
And changes
P.S. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, tests pass, LGTM
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
Description
Add
InstanceNorm
usingTensorRT InstanceNormalizationPlugin and implementation of BatchNormFixes #210
Also I checked #285
But this PR not supported TensorRT 8++
And it's a little different from mine.
gelu
)Type of change
Please delete options that are not relevant and/or add your own.
Checklist: